Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign -> gz : Remove redundant namespace references #345

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

methylDragon
Copy link
Contributor

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #345 (6cdd382) into ign-transport8 (9ba73b7) will decrease coverage by 0.01%.
The diff coverage is 84.61%.

❗ Current head 6cdd382 differs from pull request most recent head 2b71fdf. Consider uploading reports for the commit 2b71fdf to get more accurate results

@@                Coverage Diff                 @@
##           ign-transport8     #345      +/-   ##
==================================================
- Coverage           83.63%   83.61%   -0.02%     
==================================================
  Files                  51       51              
  Lines                5035     5035              
==================================================
- Hits                 4211     4210       -1     
- Misses                824      825       +1     
Impacted Files Coverage Δ
src/Packet.cc 0.00% <0.00%> (ø)
src/ign.cc 99.14% <83.33%> (ø)
log/src/Playback.cc 93.51% <100.00%> (ø)
log/src/Recorder.cc 87.20% <100.00%> (ø)
log/src/cmd/LogCommandAPI.cc 62.50% <100.00%> (ø)
src/NodeShared.cc 78.95% <100.00%> (ø)
include/ignition/transport/Discovery.hh 85.86% <0.00%> (-0.21%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: methylDragon <methylDragon@gmail.com>
Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@methylDragon methylDragon merged commit 9f38679 into ign-transport8 Aug 9, 2022
@methylDragon methylDragon deleted the namespace_cleanup branch August 9, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants