Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Windows fix from main branch #350

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Aug 29, 2022

Backport from #250 . We recently updated to ign-transport 8.3.0 on conda-forge, and in downstream tests (robotology/robotology-superbuild#1242) we experienced a Windows error that was fixed in recent version of ign/gz-transport, but that was not fixed on the ign-transport8 branch.

🦟 Bug fix

Fix compilation problem in downstream projects.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 29, 2022
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #350 (48c5a51) into ign-transport8 (9f38679) will not change coverage.
The diff coverage is n/a.

❗ Current head 48c5a51 differs from pull request most recent head c3579e9. Consider uploading reports for the commit c3579e9 to get more accurate results

@@               Coverage Diff               @@
##           ign-transport8     #350   +/-   ##
===============================================
  Coverage           83.61%   83.61%           
===============================================
  Files                  51       51           
  Lines                5035     5035           
===============================================
  Hits                 4210     4210           
  Misses                825      825           
Impacted Files Coverage Δ
include/ignition/transport/TopicStatistics.hh 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Backport from gazebosim#250

Signed-off-by: Silvio <silvio@traversaro.it>
@chapulina chapulina merged commit 9109b33 into gazebosim:ign-transport8 Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Windows Windows support
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants