Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logging tutorial highlight #357

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Conversation

caguero
Copy link
Collaborator

@caguero caguero commented Sep 9, 2022

🦟 Bug fix

Summary

The logging tutorial contains a section Using gz for recording and playing back. gz is sorrounded by backticks but it's not rendered properly. For now this pull request removes the backticks.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 9, 2022
@caguero caguero changed the base branch from ign-transport11 to gz-transport12 September 9, 2022 20:03
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #357 (3d43bb1) into gz-transport12 (3aa72e1) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           gz-transport12     #357   +/-   ##
===============================================
  Coverage           88.11%   88.11%           
===============================================
  Files                  52       52           
  Lines                4848     4848           
===============================================
  Hits                 4272     4272           
  Misses                576      576           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caguero caguero merged commit 311d9a9 into gz-transport12 Sep 9, 2022
@caguero caguero deleted the fix_logging_tutorial branch September 9, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants