Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved windows instructions #360

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 21, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Summary

Improved windows instructions

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Sep 21, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #360 (46bd832) into gz-transport12 (b214318) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           gz-transport12     #360   +/-   ##
===============================================
  Coverage           88.11%   88.11%           
===============================================
  Files                  52       52           
  Lines                4848     4848           
===============================================
  Hits                 4272     4272           
  Misses                576      576           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde merged commit 492dc4e into gz-transport12 Sep 21, 2022
@ahcorde ahcorde deleted the ahcorde/improve/windows_doc branch September 21, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants