List subscribed topics when running topic list #379
Conversation
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
|
@j-rivero , this PR requires |
caguero
added
the
needs upstream release
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
include/gz/transport/NodeShared.hh
Outdated
| @@ -218,6 +218,10 @@ namespace gz | |||
| /// \param[in] _pub Information of the remote subscriber. | |||
| public: void OnEndRegistration(const MessagePublisher &_pub); | |||
|
|
|||
| /// \brief Callback executed when a SUBSCRIBERS request is received. | |||
| /// \param[in] _pub Request. | |||
There was a problem hiding this comment.
| /// \param[in] _pub Request. |
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #379 +/- ##
==========================================
+ Coverage 87.44% 87.58% +0.14%
==========================================
Files 60 60
Lines 5177 5236 +59
==========================================
+ Hits 4527 4586 +59
Misses 650 650
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@caguero Thanks for adding this feature, this was a great pain point when trying to develop on gazebo |
Nightlies available: https://packages.osrfoundation.org/gazebo/ubuntu-nightly/pool/main/g/gz-msgs10/ |
|
CI is happy now, good to review @ahcorde! |
caguero
removed
the
needs upstream release
Not easily because we're breaking ABI here and in |
🎉 New feature
Requires gazebosim/gz-msgs#322
Closes #263
Summary
This patch includes the subscribed topics in the output of
gz topic -l.Test it
In one terminal run:
In another terminal run:
Your output should be:
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.