Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show subscribers info when running topic info #384

Merged
merged 5 commits into from
Feb 23, 2023
Merged

Conversation

caguero
Copy link
Collaborator

@caguero caguero commented Feb 15, 2023

🎉 New feature

Summary

This patch includes the subscribed topics in the output of gz topic -i.

Test it

In one terminal run:

gz topic -e -t /foo

In another terminal run:

gz topic -i -t /foo

Your output should be:

No publishers on topic [/foo]
Subscribers [Address, Message Type]:
  tcp://172.17.0.1:39133, google.protobuf.Message

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #384 (70e44a3) into main (4bbf528) will decrease coverage by 0.03%.
The diff coverage is 93.54%.

@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
- Coverage   87.58%   87.55%   -0.03%     
==========================================
  Files          60       60              
  Lines        5236     5257      +21     
==========================================
+ Hits         4586     4603      +17     
- Misses        650      654       +4     
Impacted Files Coverage Δ
src/Node.cc 91.76% <90.00%> (-0.55%) ⬇️
src/cmd/gz.cc 95.58% <100.00%> (+0.27%) ⬆️
include/gz/transport/Discovery.hh 84.64% <0.00%> (-0.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero caguero merged commit c5ad2d8 into main Feb 23, 2023
@caguero caguero deleted the topic_info_subs_main branch February 23, 2023 13:22
@iche033 iche033 added the 🎵 harmonic Gazebo Harmonic label Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants