-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility with protobuf 22 #405
Conversation
360e8fe
to
a6162eb
Compare
include/gz/transport/RepHandler.hh
Outdated
@@ -140,7 +140,11 @@ namespace ignition | |||
return false; | |||
} | |||
|
|||
#if GOOGLE_PROTOBUF_VERSION > 2999999 | |||
#if GOOGLE_PROTOBUF_VERSION >= 4022000 | |||
auto msgReq = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Remove extra space at the end of the line to make the style checker happy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
Codecov Report
@@ Coverage Diff @@
## ign-transport8 #405 +/- ##
==================================================
- Coverage 83.61% 83.56% -0.05%
==================================================
Files 51 51
Lines 5035 5039 +4
==================================================
+ Hits 4210 4211 +1
- Misses 825 828 +3
|
Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
🎉 New feature
Fix #404 by adding compatibility with protobuf >= 22 .
Summary
Similar to gazebosim/gz-msgs#346, but with an additional fix to change the removed
google::protobuf::down_cast
togoogle::protobuf::internal::DownCast
. It may not be ideal to use a function declared in aninternal::
namepsace, but that how actually the method was called in protobuf 2 when it was first used.Test it
Install protobuf 22 or 23, and compile gz-citadel against it.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.