Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Harmonic links in the tutorials #439

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Conversation

caguero
Copy link
Collaborator

@caguero caguero commented Sep 14, 2023

🦟 Bug fix

Summary

Fix the tutorial links to point to the Harmonic version.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #439 (50e8d38) into gz-transport13 (cddd341) will increase coverage by 0.15%.
Report is 6 commits behind head on gz-transport13.
The diff coverage is n/a.

❗ Current head 50e8d38 differs from pull request most recent head e1175c9. Consider uploading reports for the commit e1175c9 to get more accurate results

@@                Coverage Diff                 @@
##           gz-transport13     #439      +/-   ##
==================================================
+ Coverage           87.64%   87.79%   +0.15%     
==================================================
  Files                  59       59              
  Lines                5696     5696              
==================================================
+ Hits                 4992     5001       +9     
+ Misses                704      695       -9     

see 1 file with indirect coverage changes

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@azeey azeey added the documentation Improvements or additions to documentation label Sep 27, 2023
@caguero caguero merged commit d3a96bb into gz-transport13 Sep 27, 2023
6 checks passed
@caguero caguero deleted the fix_harmonic_links branch September 27, 2023 20:44
azeey added a commit to azeey/gz-transport that referenced this pull request Sep 27, 2023
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants