-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test refactoring part 2 #463
Conversation
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-transport12 #463 +/- ##
==================================================
+ Coverage 87.23% 87.27% +0.03%
==================================================
Files 60 60
Lines 5211 5211
==================================================
+ Hits 4546 4548 +2
+ Misses 665 663 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a small comment about two std includes
There is still a failing homebrew test (that I think is new) and also Windows is failing to clone the repo (@j-rivero?) |
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@osrf-jenkins retest this please |
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
I found the culprit here, I accidentally switched out the test executables from one that runs indefinitely to one that exits after a few seconds. It seems that on Linux runners, we are fast enough to complete the stress test in the window, where on other platforms we are too slow. I have switched the test back accordingly. |
@osrf-jenkins retest this please |
Do you know if the Windows failure is related to this PR? |
I'm not sure. On one hand I haven't seen it before, so maybe my fault, but also seems unrelated to the changes in the PR? |
Looks like there are actual multiple failing tests, but they aren't being reported correctly:
|
Looks like Windows failure may have been a flake. I will merge this and continue to monitor. |
Further cleanups to testing after the subprocess changes.
This does:
integration
folder and makes it clear which things are tests vs support executables