-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable tests of bash completion functions for gz #481
Conversation
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-transport13 #481 +/- ##
===============================================
Coverage 87.69% 87.69%
===============================================
Files 59 59
Lines 5704 5704
===============================================
Hits 5002 5002
Misses 702 702 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
homebrew
looks unhappy
I'm not sure these tests worked on homebrew before, I will limit them to just Linux. |
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Trying something slightly different and starting with |
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@scpeters did a brief inspection for me on macOS and things didn't seem to work, likely because of some security mechanism of the operating system. Since the value of this test is mainly in checking the flags for consistency and keeping them in sync between the completion scripts and the executables, running cross-platform isn't really necessary here. |
Follow-up from #478