Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a default timeout when requesting a service from CLI. #486

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

caguero
Copy link
Collaborator

@caguero caguero commented Mar 20, 2024

🦟 Bug fix

Fixes #475

This patch makes the timeout optional when requesting services from the command line.

How to test it?

Compile the transport examples and run:

./responser

And then type in a separate terminal:

gz service -s /echo --reqtype gz.msgs.StringMsg --reptype gz.msgs.StringMsg --req 'data: "Hello"'

You should receive:

data: "Hello"

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.73%. Comparing base (eac2e69) to head (0f59b2f).
Report is 6 commits behind head on gz-transport13.

Additional details and impacted files
@@                Coverage Diff                 @@
##           gz-transport13     #486      +/-   ##
==================================================
+ Coverage           87.69%   87.73%   +0.04%     
==================================================
  Files                  59       59              
  Lines                5704     5709       +5     
==================================================
+ Hits                 5002     5009       +7     
+ Misses                702      700       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@caguero caguero merged commit a3de398 into gz-transport13 Mar 21, 2024
11 checks passed
@caguero caguero deleted the default_timeout_cli branch March 21, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Optional --timeout flag in gz service -r
2 participants