Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger updates #139

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Logger updates #139

merged 2 commits into from
Aug 27, 2024

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Aug 27, 2024

🦟 Bug fix

Fixes the following issues:

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@iche033
Copy link
Contributor

iche033 commented Aug 27, 2024

I confirm this fixes the crash and new line issue I noted in gazebosim/gz-common#615 (comment)

@caguero caguero merged commit 108a052 into gz-utils3 Aug 27, 2024
11 checks passed
@caguero caguero deleted the caguero/no_eol branch August 27, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants