Fix missing msgs include and packages.xml deps #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: methylDragon <methylDragon@gmail.com>
ahcorde
approved these changes
Sep 7, 2022
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
ch3/hotfix-msgs-and-deps
branch
from
55f8d3c
to
0331e9b
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
ch3/hotfix-msgs-and-deps
branch
from
1626979
to
6463b34
Compare
mjcarroll
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Fix missing msgs include and packages.xml deps * Add additional conditions to support gz sim invocation Signed-off-by: methylDragon <methylDragon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gazebosim/gz-transport#315 broke
ros_gz_bridge/src/factories/service_factories/ros_gz_interfaces.cppbecause it was relying on an indirect transitive include ofgz-msgsthat was removed in that PR.To the best of my knowledge, this issue only really surfaces when building with
GZ_VERSION=garden, since that PR only applies from Garden onwards.This PR fixes that, as well as typos in the metapackage package.xml.
... and also adds additional conditions to shunt launch calls to
gz simas appropriate.