Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel updates for Garden build #1239

Merged
merged 31 commits into from
Dec 13, 2023
Merged

Bazel updates for Garden build #1239

merged 31 commits into from
Dec 13, 2023

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Feb 10, 2023

Updates bazel build for gazebo garden vesions. Also cleans up a few places where we were hardcoding Cmake variables.

@mjcarroll mjcarroll changed the base branch from main to sdf13 February 16, 2023 16:57
These won't be used as part of the cmake build on this branch, but are
useful for generating the same file from bazel.

Co-authored-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
Co-authored-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll changed the base branch from sdf13 to mjcarroll/backport_embedsdf February 16, 2023 18:48
Signed-off-by: Michael Carroll <michael@openrobotics.org>

Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
@mjcarroll mjcarroll self-assigned this Feb 16, 2023
@mjcarroll mjcarroll marked this pull request as ready for review February 16, 2023 19:05
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Base automatically changed from mjcarroll/backport_embedsdf to sdf13 February 17, 2023 19:05
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@azeey
Copy link
Collaborator

azeey commented Aug 10, 2023

I'm getting an error

$ bazel build //...
ERROR: Traceback (most recent call last):
        File "/home/addisuzt/ws/gz-bazel-src/sdformat/BUILD.bazel", line 6, column 6, in <toplevel>
                "add_lint_tests",
Error: file '@gz//bazel/skylark:build_defs.bzl' does not contain symbol 'add_lint_tests'
ERROR: package contains errors: sdformat
ERROR: package contains errors: sdformat: Traceback (most recent call last):
        File "/home/addisuzt/ws/gz-bazel-src/sdformat/BUILD.bazel", line 6, column 6, in <toplevel>
                "add_lint_tests",
Error: file '@gz//bazel/skylark:build_defs.bzl' does not contain symbol 'add_lint_tests'
ERROR: Skipping '//...': Error evaluating '//...': error loading package 'sdformat': Package 'sdformat' contains errors
WARNING: Target pattern parsing failed.
ERROR: Error evaluating '//...': error loading package 'sdformat': Package 'sdformat' contains errors
INFO: Elapsed time: 0.562s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (78 packages loaded)

I followed the instructions in the gz-bazel repo. Not sure if I'm doing something wrong.

@mjcarroll
Copy link
Contributor Author

mjcarroll commented Aug 10, 2023 via email

@mjcarroll mjcarroll added 🌱 garden Ignition Garden and removed beta Targeting beta release of upcoming collection labels Aug 28, 2023
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@j-rivero
Copy link
Contributor

j-rivero commented Oct 6, 2023

@osrf-jenkins run tests

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Copy link
Contributor Author

@azeey I think this one is ready for another look

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll merged commit a20cf95 into sdf13 Dec 13, 2023
13 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/garden_bazel branch December 13, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants