-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bazel updates for Garden build #1239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
mjcarroll
force-pushed
the
mjcarroll/garden_bazel
branch
from
February 16, 2023 16:56
f9be158
to
8c13dbb
Compare
These won't be used as part of the cmake build on this branch, but are useful for generating the same file from bazel. Co-authored-by: Bi0T1N <Bi0T1N@users.noreply.github.com> Co-authored-by: Michael Carroll <michael@openrobotics.org> Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
mjcarroll
force-pushed
the
mjcarroll/garden_bazel
branch
from
February 16, 2023 18:48
8c13dbb
to
8702bcd
Compare
mjcarroll
force-pushed
the
mjcarroll/garden_bazel
branch
from
February 16, 2023 18:55
8702bcd
to
2ff7986
Compare
Signed-off-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
mjcarroll
force-pushed
the
mjcarroll/garden_bazel
branch
from
February 16, 2023 19:03
2ff7986
to
1255925
Compare
Signed-off-by: Michael Carroll <michael@openrobotics.org>
mjcarroll
force-pushed
the
mjcarroll/garden_bazel
branch
from
February 16, 2023 19:13
c3626a1
to
7553e0f
Compare
mjcarroll
force-pushed
the
mjcarroll/garden_bazel
branch
from
February 16, 2023 19:52
3505ad0
to
607918f
Compare
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
mjcarroll
force-pushed
the
mjcarroll/garden_bazel
branch
from
June 12, 2023 20:12
c151b4f
to
f2b5eea
Compare
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
…arroll/garden_bazel
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
I'm getting an error
I followed the instructions in the |
That's my fault. I also updated a gz_bazel rule in a branch today. Will
let you know when it's ready again.
…On Thu, Aug 10, 2023, 3:34 PM Addisu Z. Taddese ***@***.***> wrote:
I'm getting an error
$ bazel build //...
ERROR: Traceback (most recent call last):
File "/home/addisuzt/ws/gz-bazel-src/sdformat/BUILD.bazel", line 6, column 6, in <toplevel>
"add_lint_tests",
Error: file ***@***.***//bazel/skylark:build_defs.bzl' does not contain symbol 'add_lint_tests'
ERROR: package contains errors: sdformat
ERROR: package contains errors: sdformat: Traceback (most recent call last):
File "/home/addisuzt/ws/gz-bazel-src/sdformat/BUILD.bazel", line 6, column 6, in <toplevel>
"add_lint_tests",
Error: file ***@***.***//bazel/skylark:build_defs.bzl' does not contain symbol 'add_lint_tests'
ERROR: Skipping '//...': Error evaluating '//...': error loading package 'sdformat': Package 'sdformat' contains errors
WARNING: Target pattern parsing failed.
ERROR: Error evaluating '//...': error loading package 'sdformat': Package 'sdformat' contains errors
INFO: Elapsed time: 0.562s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (78 packages loaded)
I followed the instructions in the gz-bazel repo. Not sure if I'm doing
something wrong.
—
Reply to this email directly, view it on GitHub
<#1239 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACEJFP6XGSSLNIP6COMHTDXUVATPANCNFSM6AAAAAAUYBRKD4>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
mjcarroll
added
🌱 garden
Ignition Garden
and removed
beta
Targeting beta release of upcoming collection
labels
Aug 28, 2023
@osrf-jenkins run tests |
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@azeey I think this one is ready for another look |
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
…arroll/garden_bazel
iche033
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates bazel build for gazebo garden vesions. Also cleans up a few places where we were hardcoding Cmake variables.