FrameSemantics: fix NullVertex warnings #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scpeters
changed the title
Follow-up to gz-math#606. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
force-pushed
the
scpeters/nullvertex_warnings
branch
from
2b58592
to
a81a70d
Compare
|
@osrf-jenkins run tests please |
ahcorde
approved these changes
Jul 15, 2024
caguero
approved these changes
Jul 15, 2024
scpeters
added a commit
that referenced
this pull request
Jul 17, 2024
This reverts commit e40331e. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This was referenced Jul 17, 2024
scpeters
added a commit
that referenced
this pull request
Jul 17, 2024
This reverts commit e40331e. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
8 tasks
scpeters
added a commit
that referenced
this pull request
Jul 19, 2024
Follow-up to gz-math#606. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
8 tasks
scpeters
added a commit
that referenced
this pull request
Aug 1, 2024
Follow-up to gz-math#606, retry of #1458. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes deprecation warnings caused by gazebosim/gz-math#606.
Summary
The
gz::math::graph::Vertex::NullVertexstatic type has been deprecated in gazebosim/gz-math#606 in favor ofgz::math::graph::NullVertex(), so this fixes the deprecation warnings in FrameSemantics.cc by updating to the new API.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.