error when s3 client is missing region config #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `region` configuration is missing the AWS S3 client will fail essentially all operations. This is true even if the `endpoint` is provided in the storage URL. Because the client is cached, this same failure will continue to happen, even _after_ you update `~/.aws/config` to set the `region`. This commit adds an explicit check for the `Region` when initializing a new S3 client, to prevent the invalid client configuration from being persisted in the `clients` map.
#329 introduced a change to synchronously fail shards if the result of `store.StartCommit` is immediately available. This is _technically_ a race condition, since some asynchronous operations may still completed and observed by `txnStartCommit`. This changes the test to only match against a portion of the final error message, so that it tolerates the error being returned either synchronously or asyncronously.
psFried
force-pushed
the
phil/handle-missing-region
branch
from
0927987
to
a28f803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
regionconfiguration is missing the AWS S3 client will fail essentially all operations. This is true even if theendpointis provided in the storage URL. Because the client is cached, this same failure will continue to happen, even after you update~/.aws/configto set theregion.This commit adds an explicit check for the
Regionwhen initializing a new S3 client, to prevent the invalid client configuration from being persisted in theclientsmap.This is not urgent or blocking, but I just wanted to get the fix in while I was thinking about it.
This change is