changes to replay at a post-shapella height #446
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
gballet
commented
May 29, 2024
Comment on lines
+833
to
+834
| IsEIP2929: c.IsBerlin(num), // && !c.IsPrague(num, timestamp), | ||
| IsEIP4762: false, //c.IsPrague(num, timestamp), |
There was a problem hiding this comment.
this is basically what's new: 2929 still needs to remain active, if we want to have the same gas costs.
When I'll start comparing the gas costs, I will activate 4762 and deactivate 2929 (and the check for gas consumption, of course). This means that some txs will fail when they shouldn't have (and vice-versa) but we would be able to figure it out and only take the ones that match into account.
jsign
force-pushed
the
jsign-replay-kaustinen6
branch
from
6d11543
to
e796a78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes are from #436 but some are access-list specific.