[wip] replay at 17M but deleting storage slots + accounts #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
commented
Aug 23, 2024
| @@ -193,10 +193,14 @@ func ImportChain(chain *core.BlockChain, fn string) error { | |||
| } | |||
| i := 0 | |||
| for ; i < importBatchSize; i++ { | |||
| if i == 1907 { | |||
| break | |||
There was a problem hiding this comment.
this is because the test file I have is truncated
gballet
commented
Aug 23, 2024
| @@ -289,7 +289,7 @@ func ApplyTransaction(config *params.ChainConfig, bc ChainContext, author *commo | |||
| } | |||
| // Create a new context to be used in the EVM environment | |||
| blockContext := NewEVMBlockContext(header, bc, author) | |||
| istarget := blockContext.BlockNumber.Uint64() == 17366216 | |||
| istarget := blockContext.BlockNumber.Uint64() == 17165311 | |||
There was a problem hiding this comment.
error at this location. It doesn't seem like the problem of the nyota costs, even though it's at the same block.
gballet
commented
Aug 23, 2024
Comment on lines
+213
to
+217
| for i := 0; i < 256; i++ { | ||
| key[31] = byte(i) | ||
| if root, err := t.root.(*verkle.InternalNode).Delete(key, t.FlatdbNodeResolver); root || err != nil { | ||
| return fmt.Errorf("error deleting key %x: %w", err) | ||
| } |
There was a problem hiding this comment.
need to rebase to get DeleteAtStem
|
Fails at this tx: 0x900a68afa7a2837bf2387b62c661cdec8f062e18957b7e0f9cb20b77d31cafc0 |
|
Ignacio correctly points out: on top of the conversion, deleting values isn't supported by the proof system since we can't mark something as deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: This is mostly for me to remember the current state on monday since I have to move on to something else and want to jot down notes before I do.
This approach deletes values from the verkle tree, and also from the merkle tree. It's only intended to work with block replay. Most of the difficulty comes from being pre-cancun, as accounts have to be deleted also.