crypto: added signify fuzzer #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
reviewed
Nov 19, 2020
crypto/signify_fuzz.go
Outdated
| // if signify-openbsd is present, check the signature. | ||
| // signify-openbsd will be present in CI. | ||
| if runtime.GOOS == "linux" { | ||
| cmd := exec.Command("which", "signify") |
There was a problem hiding this comment.
would it somehow be possible to pass the executable name as some parameter to Fuzz ?
There was a problem hiding this comment.
Not to fuzz, but we can pass it as an environment parameter
crypto/signify_fuzz.go
Outdated
| panic(err) | ||
| } | ||
|
|
||
| err = SignifySignFile(tmpFile.Name(), tmpFile.Name()+".sig", testSecKey, "clé", "croissants") |
There was a problem hiding this comment.
would it be possible to generate the comments as random strings instead?
MariusVanDerWijden
force-pushed
the
signify-fuzz
branch
from
fa40a06 to
a89211b
Compare
MariusVanDerWijden
force-pushed
the
signify-fuzz
branch
from
a89211b to
5304fc0
Compare
gballet
added a commit
that referenced
this pull request
Dec 4, 2020
* internal/build: implement signify's signing func * Add signify to the ci utility * fix output file format * Add unit test for signify * holiman's + travis' feedback * internal/build: verify signify's output * crypto: move signify to common dir * use go-minisign to verify binaries * more holiman feedback * crypto, ci: support minisign output * only accept one-line trusted comments * configurable untrusted comments * code cleanup in tests * revert to use ed25519 from the stdlib * bug: fix for empty untrusted comments * write timestamp as comment if trusted comment isn't present * rename line checker to commentHasManyLines * crypto: added signify fuzzer (#6) * crypto: added signify fuzzer * stuff * crypto: updated signify fuzzer to fuzz comments * crypto: repro signify crashes * rebased fuzzer on build-signify branch * hide fuzzer behind gofuzz build flag * extract key data inside a single function * don't treat \r as a newline * travis: fix signing command line * do not use an external binary in tests * crypto: move signify to crypto/signify * travis: fix formatting issue * ci: fix linter build after package move Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.