-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make constants out of non-changing variables #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build isn't broken, which version of zig are you building with?
and your change does break tests:
I'm not against merging this to accommodate future zig versions, but 0.11.0 is the reference version and needs to build. |
0.12.0-dev.1773+8a8fd47d2 |
What command do use in running your test? |
We only support the latest release, so if it breaks in The test commands can be seen in the ci file:
|
Could you please remove the .DS_Store? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for being my first contributor!👋
Fix build by changing
var
toconst
for constant values as used in current version of zig.