ITs

gbif · May 7, 2021 · 2096774 · 2096774
1 parent 1064e1b
commit 2096774
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/...sts/src/test/java/org/gbif/registry/ws/it/collections/resource/InstitutionResourceIT.java b/...sts/src/test/java/org/gbif/registry/ws/it/collections/resource/InstitutionResourceIT.java
@@ -132,8 +132,6 @@ public void convertToCollectionTest() {
         convertedCollectionKey, getClient().convertToCollection(UUID.randomUUID(), params));
   }
 
-  // TODO: suggestions
-
   @Override
   protected PrimaryCollectionEntityService<Institution> getMockPrimaryEntityService() {
     return institutionService;

diff --git a/.../java/org/gbif/registry/ws/it/collections/resource/PrimaryCollectionEntityResourceIT.java b/.../java/org/gbif/registry/ws/it/collections/resource/PrimaryCollectionEntityResourceIT.java
@@ -30,6 +30,7 @@
 import org.gbif.api.model.collections.suggestions.ChangeSuggestionService;
 import org.gbif.api.model.collections.suggestions.Status;
 import org.gbif.api.model.collections.suggestions.Type;
+import org.gbif.api.model.common.paging.Pageable;
 import org.gbif.api.model.common.paging.PagingRequest;
 import org.gbif.api.model.common.paging.PagingResponse;
 import org.gbif.api.model.registry.Commentable;
@@ -61,7 +62,6 @@
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.mockito.ArgumentMatchers.anyInt;
-import static org.mockito.ArgumentMatchers.anyString;
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.any;
 import static org.mockito.Mockito.doNothing;
@@ -253,20 +253,21 @@ public void getChangeSuggestionTest() {
   public void listChangeSuggestionTest() {
     R changeSuggestion = newChangeSuggestion();
     changeSuggestion.setKey(1);
-    when(getMockChangeSuggestionService().list(any(), any(), any(), anyString(), any(), any()))
+    Status status = Status.PENDING;
+    Type type = Type.CREATE;
+    Country country = Country.DENMARK;
+    String proposedBy = "aa@aa.com";
+    UUID entityKey = UUID.randomUUID();
+    Pageable page = new PagingRequest();
+
+    when(getMockChangeSuggestionService().list(status, type, country, proposedBy, entityKey, page))
         .thenReturn(
             new PagingResponse<>(
                 new PagingRequest(), 1L, Collections.singletonList(changeSuggestion)));
 
     PagingResponse<R> result =
         getPrimaryCollectionEntityClient()
-            .listChangeSuggestion(
-                Status.PENDING,
-                Type.CREATE,
-                Country.DENMARK,
-                "aaa@aa.com",
-                UUID.randomUUID(),
-                new PagingRequest());
+            .listChangeSuggestion(status, type, country, proposedBy, entityKey, page);
     assertEquals(1, result.getResults().size());
   }