change field stillRelevant renamed to outdated

gbif · Jun 1, 2021 · be9551c · be9551c
1 parent 3213a6e
commit be9551c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/...rg/gbif/registry/ws/it/collections/service/suggestions/BaseChangeSuggestionServiceIT.java b/...rg/gbif/registry/ws/it/collections/service/suggestions/BaseChangeSuggestionServiceIT.java
@@ -187,7 +187,7 @@ public void updateEntityChangeSuggestionTest() {
     suggestion = changeSuggestionService.getChangeSuggestion(suggKey);
     assertEquals(numberChanges, suggestion.getChanges().size());
     assertEquals(1, suggestion.getChanges().stream().filter(Change::isOverwritten).count());
-    assertEquals(1, suggestion.getChanges().stream().filter(Change::isStillRelevant).count());
+    assertEquals(1, suggestion.getChanges().stream().filter(Change::isOutdated).count());
 
     // When
     changeSuggestionService.applyChangeSuggestion(suggKey);

diff --git a/...n/java/org/gbif/registry/service/collections/suggestions/BaseChangeSuggestionService.java b/...n/java/org/gbif/registry/service/collections/suggestions/BaseChangeSuggestionService.java
@@ -473,8 +473,8 @@ protected R dtoToChangeSuggestion(ChangeSuggestionDto dto) {
                           + changeDto.getFieldName().substring(1))
                   .invoke(currentEntity);
 
-          // if it's the same as the current it's not relevant anymore
-          change.setStillRelevant(Objects.equals(currentValue, changeDto.getSuggested()));
+          // if it's the same as the current it's considered outdated
+          change.setOutdated(Objects.equals(currentValue, changeDto.getSuggested()));
           changes.add(change);
 
           if (!changeDto.isOverwritten()) {
@@ -523,6 +523,7 @@ private Change changeDtoToChange(ChangeDto dto) {
     change.setAuthor(dto.getAuthor());
     change.setCreated(dto.getCreated());
     change.setOverwritten(dto.isOverwritten());
+
     return change;
   }