Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scopes for GrSciColl users #179

Closed
marcos-lg opened this issue Mar 17, 2020 · 6 comments
Closed

Add scopes for GrSciColl users #179

marcos-lg opened this issue Mar 17, 2020 · 6 comments
Labels
GRSciColl Issues related to institutions, collections and staff

Comments

@marcos-lg
Copy link
Contributor

No description provided.

@marcos-lg marcos-lg added the GRSciColl Issues related to institutions, collections and staff label Mar 17, 2020
@ManonGros
Copy link
Contributor

We would have the two following roles:

GRSCICOLL_ADMIN:

  • Can edit everything
  • Get a warning when editing IH entry in the UI

GRSCICOLL_EDITOR:

  • Cannot edit IH_IRN identifier
  • Get a warning when editing IH entry in the UI
  • Cannot edit machineTag
  • Can create and edit all staff
  • For everything else, editor's right will depend on a scope:
    • If given institution permission:
      • can edit existing institution
      • can create and edit related collections
      • can add staff to institution and related collections
    • If given collection permission:
      • can edit existing collection
      • can add staff to collection

@marcos-lg
Copy link
Contributor Author

marcos-lg commented Jun 16, 2020

When implementing this I assumed:

  • Editing also includes deleting
  • Editors are not allowed to create institutions
  • Editors can't create collections that are not linked to any institution.
  • Editors can change the institution key of a collection if they have rights in the updated institution and they still have rights in the current collection or institution.

marcos-lg added a commit that referenced this issue Jun 16, 2020
marcos-lg added a commit that referenced this issue Jun 16, 2020
* #179 added scopes for GrSciColl entities

* #179 tightened condition for an editor to change the institution key of a collection

* #179 comment
@marcos-lg
Copy link
Contributor Author

Deployed in PROD

@MortenHofft
Copy link
Member

@marcos-lg Would it make sense to say that registry admins can edit anything? I mean, a registry admin can just edit their own roles anyway.

@marcos-lg
Copy link
Contributor Author

@MortenHofft no, registry admins can't edit anything in GRSciColl - GRSciColl uses only GRSciColl roles. I separated the roles some time ago to make GRSciColl more independent and have more control over permissions.

@MortenHofft
Copy link
Member

MortenHofft commented Jan 27, 2021

To avoid issues like gbif/registry-console#357 there is now this issue #293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GRSciColl Issues related to institutions, collections and staff
Projects
None yet
Development

No branches or pull requests

3 participants