Skip to content

Commit

Permalink
Issue crc-org#588 Remove bundle version from version section.
Browse files Browse the repository at this point in the history
Without this `version` output look following, which doesn't make sense
since now Openshift version is part of version command and contain
this detail.

```
$ ./crc version
version: 1.0.0-beta.2-4.1.11+a0732c0
OpenShift version: 4.1.11 (not embedded in binary)
```

With this change, now it looks bit sane.

```
$ ./crc version
version: 1.0.0-beta.2+a0732c0
OpenShift version: 4.1.11 (not embedded in binary)
```
  • Loading branch information
praveenkumar committed Sep 13, 2019
1 parent 8e40a2c commit 1af59dc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/crc/cmd/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ var versionCmd = &cobra.Command{
}

func runPrintVersion(arguments []string) {
fmt.Printf("version: %s-%s+%s\n", version.GetCRCVersion(), version.GetBundleVersion(), version.GetCommitSha())
fmt.Printf("version: %s+%s\n", version.GetCRCVersion(), version.GetCommitSha())
var embedded string
if constants.BundleEmbedded() {
embedded = "embedded in binary"
Expand Down

0 comments on commit 1af59dc

Please sign in to comment.