Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support strictBuiltinIteratorReturn #1949

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Support strictBuiltinIteratorReturn #1949

merged 3 commits into from
Jul 25, 2024

Conversation

rbuckton
Copy link
Contributor

@rbuckton rbuckton commented Jul 17, 2024

This updates the fp-ts build to be forwards compatible with microsoft/TypeScript#58243, which uses a stricter return type for built-in iterators under the new strictBuiltinIteratorReturn option, which is enabled by default when compiling with strict.

@rbuckton
Copy link
Contributor Author

I've filed this as a Draft PR in the event there are any other changes to microsoft/TypeScript#58243 that must be addressed. Once that PR has merged, I will mark this PR as "Ready for review".

@rbuckton rbuckton marked this pull request as ready for review July 19, 2024 21:00
@gcanti gcanti merged commit ee54608 into gcanti:master Jul 25, 2024
1 check passed
@gcanti
Copy link
Owner

gcanti commented Jul 25, 2024

Thank you @rbuckton 👍

@rbuckton rbuckton deleted the strictBuiltinIteratorReturn branch July 25, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants