Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fp ts bare import #137

Merged
merged 13 commits into from
Aug 19, 2020
Merged

fp ts bare import #137

merged 13 commits into from
Aug 19, 2020

Conversation

osdiab
Copy link
Contributor

@osdiab osdiab commented Aug 7, 2020

As of gcanti/fp-ts#1241 we can import directly from fp-ts to allow the bundler to decide which bundle to use. This applies the same build structure and output as fp-ts.

ES6 and lib folders are placed in a dist/ directory, each module has its own package.json declaring main, module, and typings.

@osdiab
Copy link
Contributor Author

osdiab commented Aug 7, 2020

docs-ts is failing from this:

docs/examples/src-clone.ts-clone-0.ts (2,23): Cannot find module 'io-ts-types/lib/clone' or its corresponding type declarations. (2307)

will look into it a bit later, time short right now

@osdiab
Copy link
Contributor Author

osdiab commented Aug 7, 2020

ah, just had some stray files in my directory, npm test fully succeeds.

@osdiab
Copy link
Contributor Author

osdiab commented Aug 8, 2020

I just emulated what was going on in fp-ts including copying over its scripts (maybe that should be exported as a library as well, as the same thing could be dumped into io-ts itself too), would love a pair of eyes that this makes sense @gcanti ! Thanks for the great project.

@osdiab
Copy link
Contributor Author

osdiab commented Aug 8, 2020

npm run test passes fully and the output directory looks correct.

@osdiab
Copy link
Contributor Author

osdiab commented Aug 10, 2020

Ready for review @gcanti !

@gcanti gcanti merged commit fd4f690 into gcanti:master Aug 19, 2020
@gcanti
Copy link
Owner

gcanti commented Aug 19, 2020

Thanks @osdiab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants