Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DateFromUnixTime.encode returning a floating point number #160

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

saevarb
Copy link
Contributor

@saevarb saevarb commented Mar 23, 2021

This solves #159 and I also figured out why the tests didn't catch this and updated them. The date used for testing did not include any hours/mins/secs/etc so this slipped through.

All tests pass except for some type-level tests which I can only assume must have failed previously?


Running type-level tests for the following versions: ["3.5","3.6","3.7","3.8","3.9","4.0","4.1","4.2"]
Error: /home/sbrg/mess/io-ts-types/dtslint/ts3.5/readonlyNonEmptyArray.ts:6:1
ERROR: 6:1  expect  Expected type to be:
  (i: unknown) => Either<Errors, ReadonlyNonEmptyArray<string>>
got:
  (i: unknown) => Validation<ReadonlyNonEmptyArray<string>>

/home/sbrg/mess/io-ts-types/dtslint/ts3.5/readonlySetFromArray.ts:7:1
ERROR: 7:1  expect  Expected type to be:
  (i: unknown) => Either<Errors, ReadonlySet<string>>
got:
  (i: unknown) => Validation<ReadonlySet<string>>

@gcanti
Copy link
Owner

gcanti commented Mar 23, 2021

All tests pass except for some type-level tests which I can only assume must have failed previously?

Looks something related to typescript@4.2, don't worry about that, I'll fix it later, thanks.

@gcanti gcanti merged commit ba2303d into gcanti:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants