Add output indexed types to option and either #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcanti
reviewed
Oct 5, 2022
| /** | ||
| * @since 0.5.18 | ||
| */ | ||
| export type NoneOutput = t.OutputOf<typeof None> |
There was a problem hiding this comment.
is there a particular reason for using t.OutputOf here?
I was expecting export type NoneOutput = { _tag: 'None' }
There was a problem hiding this comment.
Preventing double definition and possible divergence.
We should add some tests |
gcanti
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds indexed output types to the
optionandeithercodecs. This solves the problem that it is currently not possible to doJson.pipe(option(t.unknown))orJson.pipe(either(t.string, t.unknown))as thefp-tstypes can not be assigned toJsonRecord. As we don't want to loose theinterfacerepresentation infp-tsit is the best to add an indexed version toio-ts-types.This is related to gcanti/fp-ts#1734