Enable Mongo transactions for updating model cards

backend/src/services/model.ts

@@ -1,5 +1,6 @@
 import { Validator } from 'jsonschema'
 import _ from 'lodash'
+import mongoose from 'mongoose'
 
 import authentication from '../connectors/authentication/index.js'
 import { ModelAction, ModelActionKeys } from '../connectors/authorisation/actions.js'
@@ -10,9 +11,11 @@ import ModelCardRevisionModel, { ModelCardRevisionDoc } from '../models/ModelCar
 import { UserInterface } from '../models/User.js'
 import { GetModelCardVersionOptions, GetModelCardVersionOptionsKeys, GetModelFiltersKeys } from '../types/enums.js'
 import { isValidatorResultError } from '../types/ValidatorResultError.js'
+import { isReplicaSet } from '../utils/database.js'
 import { toEntity } from '../utils/entity.js'
-import { BadReq, Forbidden, NotFound } from '../utils/error.js'
+import { BadReq, Forbidden, InternalError, NotFound } from '../utils/error.js'
 import { convertStringToId } from '../utils/id.js'
+import log from './log.js'
 import { findSchemaById } from './schema.js'
 
 export function checkModelRestriction(model: ModelInterface) {
@@ -254,9 +257,21 @@ export async function _setModelCard(
   }
 
   const revision = new ModelCardRevisionModel({ ...newDocument, modelId, createdBy: user.dn })
-  await revision.save()
 
-  await ModelModel.updateOne({ id: modelId }, { $set: { card: newDocument } })
+  if (!isReplicaSet()) {
+    throw InternalError('Database is not in replica set mode, cannot use transactions')
+  }
+
+  await mongoose.connection
+    .transaction(async function executeUpdate(session) {
+      await revision.save({ session })
+      await ModelModel.updateOne({ id: modelId }, { $set: { card: newDocument } }, { session: session })
+    })
+    .catch((error) => {
+      const message = 'Unable to save model card revision'
+      log.error('Error when updating model card/revision. Transaction rolled back.', error)
+      throw InternalError(message, { modelId })
+    })
 
   return revision
 }

backend/src/utils/database.ts

@@ -31,6 +31,11 @@ export async function connectToMongoose() {
   }
 }
 
+export async function isReplicaSet(): Promise<boolean> {
+  const options = mongoose.connection.getClient().options
+  return Object.prototype.hasOwnProperty.call(options, 'replicaSet') && options.replicaSet.length > 0
+}
+
 export async function disconnectFromMongoose() {
   await mongoose.disconnect()
   log.info({ log: false }, 'Disconnected from Mongoose')

backend/test/services/model.spec.ts

@@ -57,6 +57,10 @@ const modelMocks = vi.hoisted(() => {
 })
 vi.mock('../../src/models/Model.js', () => ({ default: modelMocks }))
 
+vi.mock('../../src/utils/database.ts', async () => ({
+  isReplicaSet: vi.fn(() => true),
+}))
+
 const authenticationMocks = vi.hoisted(() => ({
   getEntities: vi.fn(() => ['user']),
 }))