Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable arg & kwarg passing to superclass for sub agents #1638

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

onecrazygenius
Copy link
Contributor

Affected core subsystem(s):

python library

Description of change:

Updated tokenagent and pkiagent to accept args and kwargs for super.init(), which will allow using these classes with verify=False

lib/python/src/bailo/core/agent.py Outdated Show resolved Hide resolved
lib/python/src/bailo/core/agent.py Outdated Show resolved Hide resolved
lib/python/src/bailo/core/agent.py Show resolved Hide resolved
lib/python/src/bailo/core/agent.py Outdated Show resolved Hide resolved
@onecrazygenius onecrazygenius force-pushed the fix/python-library branch 2 times, most recently from 5581e79 to bce6617 Compare December 6, 2024 15:24
@onecrazygenius
Copy link
Contributor Author

made changes to remove *args, but keep *kwarg forwarding to super.init

Copy link
Contributor

@PE39806 PE39806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all great. Thank you for implementing this change!

lib/python/src/bailo/core/agent.py Show resolved Hide resolved
@PE39806 PE39806 merged commit 3b58f0c into gchq:main Dec 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants