Pal 508 tidy up clients dependencies #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Few small changes * Configuration now stores Palisade and Filtered Resource urls as URU instances and not Strings. Changes made to implement this * More documentatioin about the API added to the README.md
* NOTICES.md set common and readers to snapshot * Spelling * Logging changes * Added missing register client method which should be used internally. * Better Javadoc
* Added more Javadoc * Converted comments to javadoc where ncessary * More robust client loading in ClientManager * More logging in ClientManager * More documentation around properties * Default to HTTP/1.1 * Added configuration property to enable HTTP/2 * Configured the test server for HTTP/2 * Sonar Issues
…ilt code and updated NOTICES and dependency trees
… Pal-508-clients-dependencies
m78233
reviewed
Mar 16, 2021
m78233
reviewed
Mar 16, 2021
m78233
reviewed
Mar 16, 2021
m78233
previously approved these changes
Mar 16, 2021
dbz120896
suggested changes
Mar 16, 2021
dbz120896
previously approved these changes
Mar 17, 2021
dev930018
suggested changes
Mar 18, 2021
There was a problem hiding this comment.
Basically all the changes I could see I couldn't comment on...
Properties:
'slf4j' and 'rxjava' should be at the top under 'runtime'
'json-flattener' is not needed
Unify micronaut and micronaut-test to just micronaut (2.3.2, as 2.3.4 is not available for all of them)
'junit.platform.version' is not needed
DependencyManagment:
Not needed, use is for when this is used as a parent pom. I don't see that happening
Dependencies:
You can at least drop micronaut-inject
micronaut-inject-java should be 'test' scope
dev930018
suggested changes
Mar 19, 2021
remove unused property Co-authored-by: dev930018 <56113485+dev930018@users.noreply.github.com>
dev930018
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.