Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pal 1023 s3 interceptor client #67

Merged
merged 27 commits into from
Jul 7, 2021
Merged

Pal 1023 s3 interceptor client #67

merged 27 commits into from
Jul 7, 2021

Conversation

dev930018
Copy link
Contributor

Technically Work-In-Progress but may work with S3 clients other than Spark

@dev930018 dev930018 requested a review from pd104923 June 22, 2021 09:56
pd104923
pd104923 suggested changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@pd104923 pd104923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would check SonarQube to deal with any smells as well.
While not relevant to this branch, some other changes maybe required when 684 is merged.

client-s3/pom.xml Outdated Show resolved Hide resolved
client-s3/src/main/java/uk/gov/gchq/palisade/client/s3/repository/OrphanedChildJsonMixin.java Outdated Show resolved Hide resolved
pd104923
pd104923 previously approved these changes Jun 24, 2021
View reviewed changes
ac74475
ac74475 reviewed Jun 24, 2021
View reviewed changes
client-s3/README.md Outdated Show resolved Hide resolved
@dev930018 dev930018 mentioned this pull request Jul 2, 2021
Merged
@dev930018 @developer01189998819991197253
PAL-1023 Update client-s3/src/main/java/uk/gov/gchq/palisade/client/s…
7ad799a 
…3/web/S3BucketApi.java

Co-authored-by: developer01189998819991197253 <52958809+developer01189998819991197253@users.noreply.github.com>
@developer01189998819991197253 developer01189998819991197253 deleted the PAL-1023-s3-interceptor-client branch July 7, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ac74475 ac74475 ac74475 left review comments

@developer01189998819991197253 developer01189998819991197253 developer01189998819991197253 approved these changes

@pd104923 pd104923 pd104923 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dev930018 @ac74475 @developer01189998819991197253 @pd104923