Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-12: Clean up inconsistent use of quotes in gafferpy #42

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

wb36499
Copy link
Member

@wb36499 wb36499 commented Apr 16, 2024

Replaces single quotations with double quotes for strings, bracket notation & documentation strings.

@wb36499 wb36499 self-assigned this Apr 16, 2024
@wb36499 wb36499 linked an issue Apr 16, 2024 that may be closed by this pull request
@CLAassistant
Copy link

CLAassistant commented Apr 16, 2024

CLA assistant check
All committers have signed the CLA.

@wb36499 wb36499 marked this pull request as ready for review April 16, 2024 14:38
@GCHQDeveloper314 GCHQDeveloper314 changed the title Clean up inconsistent use of quotes in gafferpy Gh-12: Clean up inconsistent use of quotes in gafferpy Apr 16, 2024
@GCHQDeveloper314
Copy link
Member

For context, previously there were 1073 instances of single quotes and 4462 instances of double quotes (found using grep -ro \' src | wc -l). I'm not sure you'd ordinarily want to use double quotes by default in Python, but there's no hard rule for it and given that single quote was less common I think it makes sense to replace them with double quotes.

@wb36499
Copy link
Member Author

wb36499 commented Apr 17, 2024

For context, previously there were 1073 instances of single quotes and 4462 instances of double quotes (found using grep -ro \' src | wc -l). I'm not sure you'd ordinarily want to use double quotes by default in Python, but there's no hard rule for it and given that single quote was less common I think it makes sense to replace them with double quotes.

I should have added that in the PR but that was essentially my rationale as well as changing any doc strings to match the PEP 8 recommendations.

@wb36499 wb36499 force-pushed the Gh-12-Clean-up-inconsistent-use-of-quotes-in-gafferpy branch from 8ff7402 to bf547ed Compare April 18, 2024 09:08
@wb36499 wb36499 merged commit 758a895 into main Apr 18, 2024
3 checks passed
@wb36499 wb36499 deleted the Gh-12-Clean-up-inconsistent-use-of-quotes-in-gafferpy branch April 18, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup inconsistent use of quotes in gafferpy
3 participants