Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-29: Fishbowl should correctly set copyright dates #57

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

GCHQDeveloper314
Copy link
Member

@GCHQDeveloper314 GCHQDeveloper314 commented Sep 20, 2024

Also includes a fix for a bug found while testing fishbowl, plus the fix for #49.

Related issue

This is set to be year range from 2022 (when fishbowl was first used) to the current year when fishbowl was run
Fixes a bug introduced in #36 which broke the generation example given in the README
Doesn't justify its own PR as this is a one charactor change
Copy link

@GCHQDeveloper314 GCHQDeveloper314 linked an issue Sep 20, 2024 that may be closed by this pull request
@tb06904 tb06904 added this to the 2.3.1 milestone Oct 4, 2024
@tb06904 tb06904 added the bug Something isn't working label Oct 4, 2024
@j69772 j69772 merged commit 9c13d0e into main Oct 10, 2024
5 checks passed
@j69772 j69772 deleted the gh-29-fishbowl-should-correctly-set-copyright-dates branch October 10, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fishbowl generated code is not compliant with PEP8 Fishbowl should correctly set copyright dates
4 participants