Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2899 - Use Bash as the entrypoint for CLI Docker images #2903

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Issue 2899 - Use Bash as the entrypoint for CLI Docker images #2903

merged 1 commit into from
Jul 15, 2024

Conversation

patchwork01
Copy link
Collaborator

Make sure you have checked all steps below.

Issue

Tests

  • My PR adds the following tests OR does not need testing for this extremely good reason:
    • Tested manually running scripts/cli/builder/build.sh then sleeper builder ./scripts/build/buildForTest.sh

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
    separate issue for that below.
  • If I have added, removed, or updated any external dependencies used in the project, I have updated the
    NOTICES file to reflect this.

@kr565370 kr565370 removed their assignment Jul 15, 2024
@patchwork01 patchwork01 merged commit 78efecb into develop Jul 15, 2024
5 checks passed
@patchwork01 patchwork01 deleted the 2899-always-invoke-cli-with-bash branch July 15, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kr565370 kr565370 kr565370 approved these changes

Assignees
No one assigned
Labels
one-review-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sleeper CLI does not use bash when invoking scripts directly
4 participants
@patchwork01 @kr565370 @gaffer01 @rtjd6554