Timestamp in metrics; vsys measurement support; voltage, heap, and rssi metrics #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also tweak the headers handler to avoid a concat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an NTP init and a timestamp to all metrics emitted. This allows prometheus to deduplicate stale sensor measurements and show the graph as it should be shown. Also added is new support for measuring the vsys voltage (this can be used to determine battery SoC and whether we should enter a lower power mode). Additional metrics are heap used, heap free, and wifi RSSI.
Finally, we now set header strings directly rather than create a new string and then concatenate.