Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upated docker commands instructions in README.md #248

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

juliocesar-io
Copy link
Contributor

@juliocesar-io juliocesar-io commented Aug 30, 2024

Small update in the README: The build command is currently failing as is. It’s missing the dot to build in the current folder.

Update: Also updated Docker run commands so I clear how to run and test with GPU support.

@RJ3
Copy link

RJ3 commented Aug 30, 2024

That dot should not be necessary if you use -f parameter. You either use one or the other but not both at the same time.

@juliocesar-io
Copy link
Contributor Author

juliocesar-io commented Aug 30, 2024

The parameter -f is used to set the filename.

 -f, --file string                   Name of the Dockerfile (default: "PATH/Dockerfile")

As for the dot, the usage is for setting the PATH. (in this case relative to current path) It can be use after the build command in any position. i.e

This works:

docker build -f Dockerfile -t diffdock .

This also works:

docker build . -f Dockerfile -t diffdock

As per the docs the default is "Dockerfile", you can also use it as:

docker build . -t diffdock

This doesn't work:

docker build -f Dockerfile -t diffdock
ERROR: "docker buildx build" requires exactly 1 argument.
See 'docker buildx build --help'.

Usage:  docker buildx build [OPTIONS] PATH | URL | -

ref: https://docs.docker.com/reference/cli/docker/buildx/build/

Docker version 27.1.1, build 6312585

@juliocesar-io juliocesar-io changed the title fix docker build command in README.md Upated docker commands instructions in README.md Aug 30, 2024
@jsilter jsilter merged commit b65b59a into gcorso:main Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants