Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for bracketed paste #286

Closed
wants to merge 1 commit into from

Conversation

joshuarubin
Copy link

Attempting to resolve #120
Does not support windows yet, but shouldn't be too hard to define a separate paste.go file for windows with the correct event information.

Rebased since #137

It's been so long that I'm not sure how to test it, but it looks right to me.

@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #286 into master will decrease coverage by 0.24%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
- Coverage   19.58%   19.34%   -0.25%     
==========================================
  Files          17       18       +1     
  Lines        1445     1463      +18     
==========================================
  Hits          283      283              
- Misses       1146     1164      +18     
  Partials       16       16
Impacted Files Coverage Δ
key.go 0% <ø> (ø) ⬆️
tscreen.go 0% <0%> (ø) ⬆️
paste.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d0b0fa...5b26aaf. Read the comment docs.

@gdamore
Copy link
Owner

gdamore commented Jun 13, 2019

This will need to be refactored in terms of the terminal descriptions. I'm not at all convinced that bracketed paste keys are universal, and I worry about possible collisions elsewhere.

@gdamore
Copy link
Owner

gdamore commented Oct 16, 2020

I've taken a different approach to this, and am also requiring applications to opt in. See #395 for my solution.

@gdamore gdamore closed this Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for bracketed paste mode
2 participants