Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for new Suspend and Resume API. #431

Merged
merged 1 commit into from
Feb 20, 2021
Merged

Support for new Suspend and Resume API. #431

merged 1 commit into from
Feb 20, 2021

Conversation

gdamore
Copy link
Owner

@gdamore gdamore commented Feb 20, 2021

fixes #194 Starting multiple screen sessions (lost key event)

You can test this by using the mouse demo, which now supports pressing
CTRL-Z. This does not actually suspend the demo, but starts a subshell
which takes over. After the subshell is exited, the demo takes control
of the screen back. This can be done multiple times, and it is possible
to start multiple "nested" iterations of the demo this way.

fixes #194 Starting multiple screen sessions (lost key event)

You can test this by using the mouse demo, which now supports pressing
CTRL-Z.  This does not actually suspend the demo, but starts a subshell
which takes over.  After the subshell is exited, the demo takes control
of the screen back.  This can be done multiple times, and it is possible
to start multiple "nested" iterations of the demo this way.
@codecov
Copy link

codecov bot commented Feb 20, 2021

Codecov Report

Merging #431 (1655637) into master (19e1709) will decrease coverage by 0.56%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
- Coverage   17.48%   16.91%   -0.57%     
==========================================
  Files          19       20       +1     
  Lines        1338     1383      +45     
==========================================
  Hits          234      234              
- Misses       1090     1135      +45     
  Partials       14       14              
Impacted Files Coverage Δ
nonblock_unix.go 0.00% <0.00%> (ø)
screen.go 0.00% <ø> (ø)
simulation.go 54.09% <0.00%> (-0.50%) ⬇️
tscreen.go 0.00% <0.00%> (ø)
tscreen_unix.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19e1709...1655637. Read the comment docs.

@gdamore gdamore merged commit 1655637 into master Feb 20, 2021
@gdamore gdamore deleted the suspend branch February 20, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting multiple screen sessions (lost key event)
1 participant