Add support for linker flags #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your patch Amy. Looks ok to me assuming @sdroege agrees with this change as well. It seems you'll have to update tests too. |
These are already detected in the pkg-config crate, but were not made available to system-deps consumers. In particular `-Wl,-rpath,/a/b/c` flags are essential to loading relocated libraries in Apple platforms.
amyspark
force-pushed
the
add-ldflags-support
branch
from
927b089
to
8c8298b
Compare
|
@gdesmott Just fixed the existing tests, and added one covering LDFLAGS. Thanks for the review! |
|
Merged and I just released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
This MR implements support for forwarding
LDFLAGSfrom pkg-config modules. These are already detected in thepkg-configcrate, but were not made available tosystem-depsconsumers. In particular-Wl,-rpath,/a/b/cflags are essential to loading relocated libraries in Apple platforms.For related issues, see:
DEP_*environment variable documentation not clear rust-lang/cargo#7846cc @sdroege