Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exported interface include dir #142

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Sep 28, 2022

include/zzip contains a header named stdint.h. This headers hides the compiler's stdint.h when a consumer links to the exported target, resulting in errors such as (cf. x64-linux in https://dev.azure.com/vcpkg/public/_build/results?buildId=78568):

error: '::int8_t' has not been declared

and (cf. x64-windows in https://dev.azure.com/vcpkg/public/_build/results?buildId=78568)

...\cstdint(31): error C2039: 'int_least8_t': is not a member of '`global namespace''
...\cstdint(31): error C2873: 'int_least8_t': symbol cannot be used in a using-d

According to the test file, the canonical pattern is #include <zzip/zzip.h>.

@gdraheim gdraheim changed the base branch from master to develop February 29, 2024 05:41
@gdraheim gdraheim merged commit 7ac88ac into gdraheim:develop Feb 29, 2024
@dg0yt dg0yt deleted the cmake-config branch February 29, 2024 05:49
@dg0yt
Copy link
Contributor Author

dg0yt commented Feb 29, 2024

Merged but not in master and not in yesterday's release? Do you plan to release another patch release very soon, before people get used to the wrong pattern?
Updating zziplib is blocked now by stdint.h again, and without feedback, I don't know which patch to apply.
microsoft/vcpkg#37043

@dg0yt
Copy link
Contributor Author

dg0yt commented Mar 6, 2024

@gdraheim Do you need more information? I would be glad to have an early indication of how you plan to proceed. Changing the include directory here after package maintainers adopted individual fixes is a waste of resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants