fix incompatible pointers #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>
fweimer-rh
reviewed
Jan 29, 2024
| @@ -664,14 +664,14 @@ zzip_disk_entry_fopen(ZZIP_DISK * disk, ZZIP_DISK_ENTRY * entry) | |||
| off_t offset = zzip_file_header_to_data(header); | |||
| if (csize == 0xFFFFu) { | |||
| struct zzip_extra_zip64* zip64 = | |||
| zzip_file_header_to_extras(header); | |||
| (struct zzip_extra_zip64*)zzip_file_header_to_extras(header); | |||
There was a problem hiding this comment.
I think this obscures a real bug: #141 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang16 and GCC 14 will make incompatible-function-pointer-types and incompatible-pointer-types and error by default.
This patch sets the functions return and parameter types to the correct expected types and casts to the expected pointer.
See also: https://wiki.gentoo.org/wiki/Modern_C_porting
Bug: https://bugs.gentoo.org/919066