Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(numerated): make refactoring for crate numerated #3597

Merged
merged 25 commits into from
Feb 28, 2024
Merged

refactor(numerated): make refactoring for crate numerated #3597

merged 25 commits into from
Feb 28, 2024

Conversation

grishasobol
Copy link
Member

@grishasobol grishasobol commented Dec 15, 2023 •
edited
Loading

Make refactoring to make code more suitable for @ark0f and @breathx

  1. rename NonEmptyInterval -> Interval
  2. rename Interval -> IntervalIterator
  3. move all iterators to file iterators.rs
  4. remove BoundValue (it's too difficult as live shows)

@grishasobol grishasobol self-assigned this Dec 15, 2023
@grishasobol grishasobol added the A1-inprogress Issue is in progress or PR draft is not ready to be reviewed label Dec 15, 2023
@grishasobol grishasobol added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Dec 20, 2023
@grishasobol grishasobol changed the title refactoring(numerated): make refactoring for crate numerated refactor(numerated): make refactoring for crate numerated Dec 29, 2023
breathx
breathx requested changes Jan 15, 2024
View reviewed changes
common/numerated/src/interval.rs Show resolved Hide resolved
common/numerated/src/interval.rs Show resolved Hide resolved
common/numerated/src/interval.rs Outdated Show resolved Hide resolved
common/numerated/src/interval.rs Show resolved Hide resolved
common/numerated/src/interval.rs Outdated Show resolved Hide resolved
common/numerated/src/tree.rs Show resolved Hide resolved
common/numerated/src/tree.rs Show resolved Hide resolved
common/numerated/src/tree.rs Show resolved Hide resolved
common/numerated/src/tree.rs Show resolved Hide resolved
common/numerated/src/tree.rs Show resolved Hide resolved
ark0f
ark0f requested changes Jan 21, 2024
View reviewed changes
common/numerated/src/tests.rs Outdated Show resolved Hide resolved
common/numerated/src/interval.rs Show resolved Hide resolved
common/numerated/src/interval.rs Show resolved Hide resolved
common/numerated/src/interval.rs Show resolved Hide resolved
common/numerated/src/interval.rs Show resolved Hide resolved
common/numerated/src/iterators.rs Show resolved Hide resolved
common/numerated/src/numerated.rs Show resolved Hide resolved
common/numerated/src/tree.rs Show resolved Hide resolved
common/numerated/src/tree.rs Outdated Show resolved Hide resolved
common/numerated/src/tree.rs Show resolved Hide resolved
@breathx breathx added A3-gotissues PR occurred to have issues after the review and removed A0-pleasereview PR is ready to be reviewed by the team labels Jan 29, 2024
@NikVolf NikVolf added A0-pleasereview PR is ready to be reviewed by the team and removed A3-gotissues PR occurred to have issues after the review labels Feb 25, 2024
breathx
breathx approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the comments mostly point author attention on some places and are not necessary to implement

Huge work done! 🎆

common/numerated/src/numerated.rs Outdated Show resolved Hide resolved
common/numerated/src/interval.rs Show resolved Hide resolved
common/numerated/src/interval.rs Show resolved Hide resolved
common/numerated/src/iterators.rs Outdated Show resolved Hide resolved
common/numerated/src/iterators.rs Show resolved Hide resolved
common/numerated/src/tree.rs Show resolved Hide resolved
common/numerated/src/tree.rs Show resolved Hide resolved
@breathx breathx added the A2-mergeoncegreen PR is ready to merge after CI passes label Feb 26, 2024
@breathx breathx removed the A0-pleasereview PR is ready to be reviewed by the team label Feb 27, 2024
@grishasobol grishasobol merged commit d205972 into master Feb 28, 2024
18 checks passed
@grishasobol grishasobol deleted the gsobol-numerated-refactoring branch February 28, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx approved these changes

@ukint-vs ukint-vs ukint-vs approved these changes

@ark0f ark0f ark0f approved these changes

Assignees

@grishasobol grishasobol

Labels
A2-mergeoncegreen PR is ready to merge after CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@grishasobol @ark0f @breathx @ukint-vs @NikVolf