Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(pallets): add instantiate_module_* benches per section #3929

Merged
merged 8 commits into from
May 16, 2024
Merged

test(pallets): add instantiate_module_* benches per section #3929

merged 8 commits into from
May 16, 2024

Conversation

ByteNacked
Copy link
Member

@ByteNacked ByteNacked commented Apr 29, 2024 •
edited
Loading

Closes #3907 .
Closes #3942 .

Add instantiate_module_* benchmarks, namely:

  • instantiate_module_data_section_per_kb
  • instantiate_module_global_section_per_kb
  • instantiate_module_table_section_per_kb
  • instantiate_module_type_section_per_kb

@reviewer-or-team

@ByteNacked ByteNacked added the A0-pleasereview PR is ready to be reviewed by the team label Apr 29, 2024
@ByteNacked ByteNacked self-assigned this Apr 29, 2024
@ByteNacked ByteNacked force-pushed the rmasl-data-section-size-bench branch from db47a7f to 2137fa9 Compare April 29, 2024 21:36
grishasobol
grishasobol reviewed May 1, 2024
View reviewed changes
Copy link
Member

@grishasobol grishasobol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update weights files adding corresponding weight in this PR.

@ByteNacked
Copy link
Member Author

Please update weights files adding corresponding weight in this PR.

Fixed

@ByteNacked ByteNacked changed the title test(pallets): add instantiate_module_with_data_section_per_kb bench test(pallets): add instantiate_module_data_section_per_kb bench May 2, 2024
breathx
breathx reviewed May 6, 2024
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but how would they be used and when?

@ByteNacked
Copy link
Member Author

Overall looks good, but how would they be used and when?

It will be used in this draft #3937 when its ready

@grishasobol grishasobol added the A5-dontmerge PR should not be merged yet label May 6, 2024
@ByteNacked ByteNacked changed the title test(pallets): add instantiate_module_data_section_per_kb bench test(pallets): add instantiate_module_* benches per section May 9, 2024
@ByteNacked
Copy link
Member Author

ByteNacked commented May 9, 2024 •
edited
Loading

  • Add additional benches per section
  • Updated weights

@ByteNacked ByteNacked removed the A5-dontmerge PR should not be merged yet label May 9, 2024
breathx
breathx approved these changes May 13, 2024
View reviewed changes
pallets/gear/src/benchmarking/mod.rs Show resolved Hide resolved
pallets/gear/src/benchmarking/code.rs Show resolved Hide resolved
@breathx breathx added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels May 13, 2024
@ByteNacked ByteNacked mentioned this pull request May 13, 2024
Merged
@ByteNacked ByteNacked requested a review from breathx May 14, 2024 09:44
@breathx
Copy link
Member

breathx commented May 14, 2024

Ready to be merged @grishasobol ?

@ByteNacked ByteNacked merged commit c5d1bd7 into master May 16, 2024
10 checks passed
@ByteNacked ByteNacked deleted the rmasl-data-section-size-bench branch May 16, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grishasobol grishasobol grishasobol approved these changes

@ark0f ark0f Awaiting requested review from ark0f

@ukint-vs ukint-vs Awaiting requested review from ukint-vs

@breathx breathx Awaiting requested review from breathx

Assignees

@ByteNacked ByteNacked

Labels
A2-mergeoncegreen PR is ready to merge after CI passes
Projects
None yet
Milestone
No milestone
4 participants
@ByteNacked @breathx @grishasobol @ukint-vs