Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove pause program storage code #3947

Merged
merged 29 commits into from
Jun 21, 2024
Merged

chore: remove pause program storage code #3947

merged 29 commits into from
Jun 21, 2024

Conversation

playX18
Copy link
Member

@playX18 playX18 commented May 6, 2024

@playX18 playX18 added the A0-pleasereview PR is ready to be reviewed by the team label May 6, 2024
@playX18 playX18 requested a review from breathx May 6, 2024 12:20
@playX18 playX18 self-assigned this May 6, 2024
@grishasobol grishasobol added the A5-dontmerge PR should not be merged yet label May 7, 2024
@playX18 playX18 requested a review from grishasobol May 8, 2024 08:48
@playX18 playX18 requested a review from gshep May 10, 2024 08:57
breathx
breathx requested changes May 13, 2024
View reviewed changes
common/src/lib.rs Outdated Show resolved Hide resolved
common/src/program_storage.rs Outdated Show resolved Hide resolved
common/src/scheduler/task.rs Show resolved Hide resolved
pallets/gear-program/src/lib.rs Outdated Show resolved Hide resolved
pallets/gear-program/src/migration.rs Outdated Show resolved Hide resolved
breathx
breathx requested changes May 14, 2024
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost great!
A few last steps left

pallets/gear/src/manager/task.rs Outdated Show resolved Hide resolved
pallets/gear/src/manager/task.rs Show resolved Hide resolved
pallets/gear-program/src/migration.rs Outdated Show resolved Hide resolved
pallets/gear-program/src/migration.rs Outdated Show resolved Hide resolved
pallets/gear-program/src/lib.rs Show resolved Hide resolved
common/src/scheduler/task.rs Show resolved Hide resolved
@breathx breathx added A3-gotissues PR occurred to have issues after the review and removed A0-pleasereview PR is ready to be reviewed by the team labels May 14, 2024
@playX18 playX18 requested a review from breathx May 15, 2024 04:56
@playX18 playX18 added the A0-pleasereview PR is ready to be reviewed by the team label May 20, 2024
grishasobol
grishasobol reviewed May 24, 2024
View reviewed changes
Copy link
Member

@grishasobol grishasobol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts

@breathx
Copy link
Member

breathx commented May 26, 2024

@playX18 ⬆️

@playX18 playX18 requested a review from grishasobol May 26, 2024 13:50
grishasobol
grishasobol approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@grishasobol grishasobol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

breathx
breathx approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 👍🏻

common/src/scheduler/task.rs Outdated Show resolved Hide resolved
@breathx breathx added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team A3-gotissues PR occurred to have issues after the review A5-dontmerge PR should not be merged yet labels Jun 11, 2024
@breathx
Copy link
Member

breathx commented Jun 11, 2024

Resolve conflicts please @playX18

@grishasobol grishasobol merged commit a9b72c1 into master Jun 21, 2024
10 checks passed
@grishasobol grishasobol deleted the ap/remove-pause-program-code branch June 21, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx approved these changes

@grishasobol grishasobol grishasobol approved these changes

@gshep gshep Awaiting requested review from gshep

Assignees

@playX18 playX18

Labels
A2-mergeoncegreen PR is ready to merge after CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@playX18 @breathx @gshep @grishasobol @playXE