feat(pallet_gear): Introduce invariant: all user non-reply messages go to mailbox #4060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techraed
added
A0-pleasereview
ark0f
approved these changes
Jul 18, 2024
techraed
changed the title
breathx
requested changes
Jul 24, 2024
There was a problem hiding this comment.
As far as I remember, it was discussed to impl the invariant in the way that every gasLESS messages sent to user requires MB threshold so further inserted in mailbox in case of user sending. At this point it applies for all messages, which is incorrect with initial idea. Furthermore, isn't the implementation panic when sends with gas = 1 to user? Seems like this.
|
Discussed: the issue is that 0 gas limit for gasful messages is a legit case. So that's going to be re-introduced. |
|
@breathx ptal |
breathx
requested changes
Jul 30, 2024
breathx
approved these changes
Jul 30, 2024
techraed
added
A2-mergeoncegreen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: All instant (no delay) user non-reply ("handle") messages are now sent to mailbox.
Completely removes
safe_gasful_sendas it introduced some implicit risky invariants. All user messages now go to mailbox, except for reply messages (as it was before)