Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gtest): Update gtest weights to match onchain weights #4088

Merged
merged 3 commits into from
Aug 11, 2024

Conversation

playX18
Copy link
Member

@playX18 playX18 commented Jul 25, 2024

Resolves #4085

At the moment update is done by hand by updating/adding constants but in the future gear-weight-diff crate should be modified to allow dumping all constants into json and generating schedule.rs file. I've tried to modify it but since it parses pallet/gear/schedule.rs to generate a new schedule.rs we can't dump costs defined in core-processor (ProcessCosts).

@breathx

@playX18 playX18 requested a review from breathx July 25, 2024 07:24
@playX18 playX18 added the A0-pleasereview PR is ready to be reviewed by the team label Jul 26, 2024
@techraed techraed added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels Aug 7, 2024
@breathx breathx merged commit e8e01a8 into master Aug 11, 2024
11 checks passed
@breathx breathx deleted the ap/gtest-weights branch August 11, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2-mergeoncegreen PR is ready to merge after CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use real non-syscall weight for gtest
4 participants