Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gtest): Delayed dispatches and charging for holding #4157

Merged
merged 15 commits into from
Aug 27, 2024
Merged

feat(gtest): Delayed dispatches and charging for holding #4157

merged 15 commits into from
Aug 27, 2024

Conversation

playX18
Copy link
Member

@playX18 playX18 commented Aug 15, 2024

Implementing delayed dispatches and charge for holding data in storage

@playX18 playX18 added the A1-inprogress Issue is in progress or PR draft is not ready to be reviewed label Aug 15, 2024
@playX18 playX18 requested a review from techraed August 15, 2024 04:45
@playX18 playX18 self-assigned this Aug 15, 2024
techraed
techraed reviewed Aug 23, 2024
View reviewed changes
Copy link
Member

@techraed techraed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

I'd move logic related to hold bounds to tasks, or a submodule of manager. Also I'd move the reservation related stuff to some manager's submodule too. Generally, need to make the manager.rs more readable.

gtest/src/manager/task.rs Outdated Show resolved Hide resolved
gtest/src/manager.rs Outdated Show resolved Hide resolved
gtest/src/manager.rs Outdated Show resolved Hide resolved
gtest/src/manager.rs Show resolved Hide resolved
gtest/src/manager.rs Outdated Show resolved Hide resolved
gtest/src/manager.rs Outdated Show resolved Hide resolved
gtest/src/manager.rs Outdated Show resolved Hide resolved
gtest/src/manager.rs Outdated Show resolved Hide resolved
gtest/src/manager.rs Outdated Show resolved Hide resolved
gtest/src/manager.rs Outdated Show resolved Hide resolved
@playX18 playX18 added the A0-pleasereview PR is ready to be reviewed by the team label Aug 26, 2024
@playX18 playX18 marked this pull request as ready for review August 26, 2024 04:53
@playX18 playX18 requested a review from techraed August 26, 2024 05:10
techraed
techraed approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@techraed techraed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reservations related methods are still not moved to a separate module.

gtest/src/gas_tree.rs Outdated Show resolved Hide resolved
gtest/src/manager.rs Outdated Show resolved Hide resolved
gtest/src/manager/hold_bound.rs Outdated Show resolved Hide resolved
gtest/src/manager.rs Outdated Show resolved Hide resolved
gtest/src/manager/hold_bound.rs Show resolved Hide resolved
@techraed techraed added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Aug 27, 2024
@playX18 playX18 merged commit 09977f4 into master Aug 27, 2024
10 checks passed
@playX18 playX18 deleted the ap/gtest-delayed branch August 27, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techraed techraed techraed approved these changes

Assignees

@playX18 playX18

Labels
A2-mergeoncegreen PR is ready to merge after CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@playX18 @techraed