fix(core-processor): Force *_input syscalls to return an error on out of bounds offset and len params.
#4186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techraed
added
the
A1-inprogress
techraed
added
A0-pleasereview
techraed
added
the
B1-releasenotes
techraed
changed the title
*_input syscalls to return error on out of range params.*_input syscalls to return an error on out of range offset and len params.
techraed
changed the title
*_input syscalls to return an error on out of range offset and len params.*_input syscalls to return an error on out of bounds offset and len params.
breathx
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: This PR fixes 2 error cases with
*_inputsyscalls. First - whenoffsetvalue is greater than a payload length, second - when alenvalue is greater than payload length. Both of these cases didn't force the syscall to return an error, so the caller (program) actually considers that provided inputs are valid and expects to have a message with a corresponding payload/payload length.@gear-tech/dev