Skip to content

Commit

Permalink
Calling proxy doesn't remove announcement (paritytech#13267)
Browse files Browse the repository at this point in the history
* Calling proxy doesn't remove announcement

* Update frame/proxy/src/tests.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* fmt

---------

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
  • Loading branch information
2 people authored and ark0f committed Feb 27, 2023
1 parent 023fe06 commit 9812a68
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 2 deletions.
2 changes: 0 additions & 2 deletions frame/proxy/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,6 @@ pub mod pallet {
/// Dispatch the given `call` from an account that the sender is authorised for through
/// `add_proxy`.
///
/// Removes any corresponding announcement(s).
///
/// The dispatch origin for this call must be _Signed_.
///
/// Parameters:
Expand Down
17 changes: 17 additions & 0 deletions frame/proxy/src/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,23 @@ fn announcer_must_be_proxy() {
});
}

#[test]
fn calling_proxy_doesnt_remove_announcement() {
new_test_ext().execute_with(|| {
assert_ok!(Proxy::add_proxy(RuntimeOrigin::signed(1), 2, ProxyType::Any, 0));

let call = Box::new(call_transfer(6, 1));
let call_hash = BlakeTwo256::hash_of(&call);

assert_ok!(Proxy::announce(RuntimeOrigin::signed(2), 1, call_hash));
assert_ok!(Proxy::proxy(RuntimeOrigin::signed(2), 1, None, call));

// The announcement is not removed by calling proxy.
let announcements = Announcements::<Test>::get(2);
assert_eq!(announcements.0, vec![Announcement { real: 1, call_hash, height: 1 }]);
});
}

#[test]
fn delayed_requires_pre_announcement() {
new_test_ext().execute_with(|| {
Expand Down

0 comments on commit 9812a68

Please sign in to comment.